Closed jubayed closed 3 months ago
I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!
Overview
This pull request addresses an issue with the Laravel Artisan Tinker command where the vendor directory path might not be correctly determined when developers customize the vendor directory. This fix ensures flexibility in determining the vendor directory path while resolving issues with running the Laravel Artisan Tinker command in various environments.
Changes
InstalledVersions::getRootPackage()
.Env::get
to retrieve theCOMPOSER_VENDOR_DIR
environment variable, allowing developers to customize the vendor directory path.Detailed Changes
Testing
Verified that the
php artisan tinker
command works correctly with and without theCOMPOSER_VENDOR_DIR
environment variable set. Ensured that the fallback toInstalledVersions::getRootPackage()
is correctly handled when the vendor directory does not exist.Impact
This fix ensures that developers have the flexibility to customize the vendor directory path while maintaining the stability of the Laravel Artisan Tinker command in various deployment environments.
Please review the changes and provide feedback. This revision emphasizes the importance of flexibility in determining the vendor directory path, accommodating developers who may customize this directory according to their needs.