search

laravel / tinker

Powerful REPL for the Laravel framework.
https://laravel.com/docs/artisan#tinker
MIT License
7.34k stars 130 forks source link

Moved config to file #68

Closed finagin closed 5 years ago

finagin commented 5 years ago

Fix #63 if append 'usePcntl' => false, to tinker.config section

taylorotwell commented 5 years ago

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

finagin commented 5 years ago

@taylorotwell, this change will allow you to fine tinker and resolve the issue #63

driesvints commented 5 years ago

@finagin as noted in the issue disabling jit isn't a solution but a bandaid. The problem with Homebrew needs to be fixed.

finagin commented 5 years ago

@driesvints, however, it would be nice to be able to fine-tune the psy/psysh.

bobthecow commented 5 years ago

You can already fine-tune the PsySH configuration via a local .psysh.php config file in your project, or a user-level config at ~/.config/psysh/config.php. It's probably not necessary to add yet another way to configure it.