[2.x] Update constraints

laravel / tinker

Powerful REPL for the Laravel framework.

https://laravel.com/docs/artisan#tinker

MIT License

7.33k stars 130 forks source link

[2.x] Update constraints #80

Closed driesvints closed 4 years ago

driesvints commented 4 years ago

This PR:

Drops support for Laravel 5.x versions
Drops support for Symfony 3.x
Requires a minimum of PHP 7.2
Add support for Symfony 5.0

This will need to be a new major version release.

Might want to wait with merging this until https://github.com/bobthecow/psysh/pull/577 is merged and tagged.

GrahamCampbell commented 4 years ago

This seems a bit premature. It' possible (in fact, likely), that psysh 0.9.x will never support Symfony 5, only the next breaking version of psysh might.

driesvints commented 4 years ago

@GrahamCampbell how so? Doesn't seems like https://github.com/bobthecow/psysh/pull/577 contains any breaking changes?

GrahamCampbell commented 4 years ago

No, but it's been a year since the last release, and there are other changes that are likely to mean the next release will be 0.10.0.

bobthecow commented 4 years ago

Give me a heads up next time and I’ll cut a release ahead of Tinker’s 😛

The next PsySH release will be a “major” version (or whatever you call it because v0.x 😒) because there are several other breaking changes in the development branch already.

But it seems worth also adding a new v0.9.x release adding Symfony 5 support.

bobthecow commented 4 years ago

Ok! PsySH supports Symfony 5.0 as of v0.9.11, so this’ll work without any changes to your constraints.

GrahamCampbell commented 4 years ago

👍

driesvints commented 4 years ago

Thanks @bobthecow!