Closed stephanvane closed 3 years ago
drbyte
commented
3 years ago @stephanvane I'm sure you have your reasons, and they're related to your workflow, but for future design consideration it would be helpful to understand those reasons more clearly. So ...
Question: Why do you want unsecure proxies? And is there a technical reason for wanting to bypass using SSL?
stephanvane
commented
3 years ago Hi @drbyte, thanks for your answer
I think that in general it would be for the same reason anyone wants to bypass SSL on parked / linked apps. There must be a reason why valet includes the valet secure/unsecure commands at all :-)
In my specific case, I wanted to have a valet-proxied-app communicate with a http-only-local-api that was running. Unfortunately the browser blocked http resources requested from an https website.
If we decide to not to allow bypassing SSL for proxies, I think it should be reflected in the documentation, and return message.
The current message of The [foo.test] site will now serve traffic over HTTP. while in reality the proxy is removed completely is confusing at least.
drbyte
commented
3 years ago Do the changes proposed in #1005 accommodate the requirements you mention?
stephanvane
commented
3 years ago For my case, this would technically solve the problem, thank you!
From a usability's perspective I would propose using a more standard way of configuring it. having two different methods (valet unsecure foo and valet proxy --unsecure) and two differents defaults (secure for proxy / unsecure for park/link) might be confusing.
Using the same methods for both park/link and proxy would be more straightforward in my opinion.
valet link foo
valet secure foo / valet unsecure foo
valet unlink
valet proxy foo http://example.com
valet secure foo / valet unsecure foo
valet unproxy foo
euoia
commented
3 years ago Is this still an issue? There seems to be a change between Valet 2.14.0 and 2.15.0 that valet proxy no longer creates an nginx configuration that listens on port 443, and instead now requires the --secure flag to listen on port 443.
drbyte
commented
3 years ago Correct. This issue can be closed due to the changes in 2.15.0
/cc @mattstauffer
Clear description of your problem
All proxies are using SSL by default. Trying to run
valet unsecureremoves the proxy completelyExpected behavior
minor issue:
valet proxy foo http://example.comshould leave SSL off by default, as the documentation suggests:main issue:
valet unsecure foodoesn't remove SSL, but removes the proxy completely.Current behavior
valet proxyenables SSL by default, and redirects http traffic to httpsSteps to Reproduce
valet proxy foo http://example.comvalet proxies # shows 'foo' with SSL enabledvalet unsecure foo # "The [foo.test] site will now serve traffic over HTTP."valet proxies # 'foo' is now completely goneValet unsecure removes the
foo.testfile that was in~/.config/valet/Nginx/Diagnosis
sw_vers
valet --version
cat ~/.config/valet/config.json
{ "tld": "test", "paths": [ "/Users/stephan/.config/valet/Sites" ] }cat ~/.composer/composer.json
{ "require": { "laravel/valet": "^2.13", "squizlabs/php_codesniffer": "^3.5" } }composer global diagnose
composer global outdated
ls -al /etc/sudoers.d/
brew config
brew services list
brew list --formula --versions | grep -E "(php|nginx|dnsmasq|mariadb|mysql|mailhog|openssl)(@\d\..*)?\s"
brew outdated
brew tap
php -v
PHP 7.4.13 (cli) (built: Nov 30 2020 14:46:04) ( NTS ) Copyright (c) The PHP Group Zend Engine v3.4.0, Copyright (c) Zend Technologies with Xdebug v2.9.8, Copyright (c) 2002-2020, by Derick Rethans with Zend OPcache v7.4.13, Copyright (c), by Zend Technologieswhich -a php
php --ini
nginx -v
curl --version
php --ri curl
~/.composer/vendor/laravel/valet/bin/ngrok version
ls -al ~/.ngrok2
brew info nginx
nginx: stable 1.19.5 (bottled), HEAD HTTP(S) server and reverse proxy, and IMAP/POP3 proxy server https://nginx.org/ /usr/local/Cellar/nginx/1.19.4 (22 files, 2.2MB) Built from source /usr/local/Cellar/nginx/1.19.5 (25 files, 2.2MB) * Poured from bottle on 2020-12-07 at 10:38:46 From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/nginx.rb License: BSD-2-Clause ==> Dependencies Required: openssl@1.1, pcre ==> Options --HEAD Install HEAD version ==> Caveats Docroot is: /usr/local/var/www The default port has been set in /usr/local/etc/nginx/nginx.conf to 8080 so that nginx can run without sudo. nginx will load all files in /usr/local/etc/nginx/servers/. To have launchd start nginx now and restart at login: brew services start nginx Or, if you don't want/need a background service you can just run: nginx ==> Analytics install: 45,007 (30 days), 125,534 (90 days), 448,115 (365 days) install-on-request: 44,409 (30 days), 123,614 (90 days), 436,308 (365 days) build-error: 0 (30 days)brew info php
php: stable 8.0.0 (bottled), HEAD General-purpose scripting language https://www.php.net/ /usr/local/Cellar/php/7.4.12 (495 files, 72.3MB) Built from source /usr/local/Cellar/php/8.0.0 (499 files, 77.8MB) Poured from bottle on 2020-11-30 at 10:57:16 From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/php.rb License: PHP-3.01 ==> Dependencies Build: httpd, pkg-config Required: apr, apr-util, argon2, aspell, autoconf, curl, freetds, gd, gettext, glib, gmp, icu4c, krb5, libffi, libpq, libsodium, libzip, oniguruma, openldap, openssl@1.1, pcre2, sqlite, tidy-html5, unixodbc ==> Options --HEAD Install HEAD version ==> Caveats To enable PHP in Apache add the following to httpd.conf and restart Apache: LoadModule php_module /usr/local/opt/php/lib/httpd/modules/libphp.so
SetHandler application/x-httpd-php
Finally, check DirectoryIndex includes index.php
DirectoryIndex index.php index.html
The php.ini and php-fpm.ini file can be found in:
/usr/local/etc/php/8.0/
To have launchd start php now and restart at login:
brew services start php
Or, if you don't want/need a background service you can just run:
php-fpm
==> Analytics
install: 64,047 (30 days), 170,576 (90 days), 596,321 (365 days)
install-on-request: 62,712 (30 days), 167,183 (90 days), 570,119 (365 days)
build-error: 0 (30 days)brew info openssl
openssl version -a
openssl ciphers
sudo nginx -t
which -a php-fpm
/usr/local/opt/php/sbin/php-fpm -v
PHP 8.0.0 (fpm-fcgi) (built: Nov 26 2020 17:53:14) Copyright (c) The PHP Group Zend Engine v4.0.0-dev, Copyright (c) Zend Technologies with Zend OPcache v8.0.0, Copyright (c), by Zend Technologiessudo /usr/local/opt/php/sbin/php-fpm -y /usr/local/etc/php/7.4/php-fpm.conf --test
ls -al ~/Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchDaemons | grep homebrew
ls -aln /etc/resolv.conf
cat /etc/resolv.conf