Closed chris-ware closed 1 year ago
naabster
commented
1 year ago I found the valet link --isolate --secure foobarcommand does indeed link the correct domain (foobar.test), but the PHP version in .valetrc is ignored.
The --isolate switch does read the .valetrc file, but use it only for the isolation of the folders name, not the custom link "foobar" provided
mattstauffer
commented
1 year ago I think we have two separate issues. @naabster would you mind spinning up a separate issue for that?
mattstauffer
commented
1 year ago I made a tiny bit of progress but then had to leave earlier than expected. Here's what I did:
cd /tmp
mkdir linking-as-not-foobar
cd linking-as-not-foobar
echo "php=php@8.0" > .valetrc
valet link foobar --isolateand here's my error:
So as we can see, we get this error when trying to isolate the directory:
at /Users/mattstauffer/.composer/vendor/laravel/valet/cli/Valet/Site.php:182
Valet\Site->getSiteUrl() at /Users/mattstauffer/.composer/vendor/laravel/valet/cli/Valet/PhpFpm.php:171
Valet\PhpFpm->isolateDirectory() at /Users/mattstauffer/.composer/vendor/laravel/valet/cli/includes/facades.php:22It's passing in the directory instead of the isolated short name. Hopefully that's an easy fix when I have a bit more time!
mcaskill
commented
1 year ago I'm new to Valet and I stumbled upon this exact issue. I organize my projects something like this:
~/Projects/
└── <domain>
└── <subdomain> # 'www' for root
├── _codebase/ # vcs repository
│ └── public/ # document root
└── _resources/ # files, presentation, artifacts, etc.This incidentally results in the same issue:
~/Projects/example.com/www/_codebase
$ valet link example --secure --isolate
A [example] symbolic link has been created in [~/.config/valet/Sites/example].
Restarting nginx...
The [example.test] site has been secured with a fresh TLS certificate.
Found '_codebase/.valetrc' or '_codebase/.valetphprc' specifying version: php@8.1
In Site.php line 182:
The [_codebase] site could not be found in Valet's site list.
link [--secure] [--isolate] [--] [<name>]It took me a while to figure it out—given the many different ways Valet resolves sites—but the issue stems from the isolate command defaulting to the current directory's name instead of the full path like the secure command does.
A simple solution to this: provide the --site= option to the isolate sub-command with the given link name:
if (Site::phpRcVersion($name)) {
- $this->runCommand('isolate');
+ $this->runCommand('isolate --site="'.$name.'"');
} else {Unfortunately, this does not work since mnapoli/silly v1.8.1 which introduced an untested change to how sub-commands are handled as a consequence of a easily confusing error message from symfony/console.
See mnapoli/silly#69 for further details, mnapoli/silly#70 for the fix of the dependency, and laravel/valet#1428 for the fix of this issue.
driesvints
commented
1 year ago Will be in today's release. Thanks all
Description:
When running
valet link --isolatewith a custom name that doesn't match the directory name, such asvalet link foobar --isolate, where the directory the site is in may be foobar.com, the isolate command doesn't seem to receive the custom name and ends up failing with the following validation error.Steps To Reproduce:
valet link --isolate foobarDiagnosis
sw_vers
valet --version
cat ~/.config/valet/config.json
{ "tld": "test", "loopback": "127.0.0.1", "paths": [ "/Users/chrisware/.config/valet/Sites" ] }cat ~/.composer/composer.json
{ "require": { "beyondcode/expose": "^2.2", "laravel/envoy": "^2.8", "laravel/forge-cli": "^1.3", "laravel/installer": "^4.2", "laravel/pint": "^1.1", "laravel/valet": "^4.0", "statamic/cli": "^2.4", "tightenco/takeout": "^2.1" }, "config": { "allow-plugins": { "ergebnis/composer-normalize": true }, } }composer global diagnose
composer global outdated
ls -al /etc/sudoers.d/
brew config
brew services list
brew list --formula --versions | grep -E "(php|nginx|dnsmasq|mariadb|mysql|mailhog|openssl)(@\d\..*)?\s"
brew outdated
brew tap
php -v
PHP 8.2.3 (cli) (built: Feb 15 2023 00:58:03) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.3, Copyright (c) Zend Technologies with Zend OPcache v8.2.3, Copyright (c), by Zend Technologieswhich -a php
php --ini
nginx -v
curl --version
php --ri curl
/opt/homebrew/bin/ngrok version
ls -al ~/.ngrok2
brew info nginx
==> nginx: stable 1.23.3 (bottled), HEAD HTTP(S) server and reverse proxy, and IMAP/POP3 proxy server https://nginx.org/ /opt/homebrew/Cellar/nginx/1.23.3 (26 files, 2.2MB) * Poured from bottle using the formulae.brew.sh API on 2023-02-15 at 12:40:44 From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/nginx.rb License: BSD-2-Clause ==> Dependencies Required: openssl@1.1, pcre2 ==> Options --HEAD Install HEAD version ==> Caveats Docroot is: /opt/homebrew/var/www The default port has been set in /opt/homebrew/etc/nginx/nginx.conf to 8080 so that nginx can run without sudo. nginx will load all files in /opt/homebrew/etc/nginx/servers/. To start nginx now and restart at login: brew services start nginx ==> Analytics install: 4,380 (30 days), 86,587 (90 days), 427,469 (365 days) install-on-request: 4,365 (30 days), 86,457 (90 days), 426,747 (365 days) build-error: 0 (30 days)brew info php
==> php: stable 8.2.4 (bottled), HEAD General-purpose scripting language https://www.php.net/ /opt/homebrew/Cellar/php/8.1.12 (193 files, 33.8MB) Built from source /opt/homebrew/Cellar/php/8.2.3 (519 files, 83.3MB) * Poured from bottle on 2023-02-15 at 12:37:35 From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/php.rb License: PHP-3.01 ==> Dependencies Build: httpd, pkg-config Required: apr, apr-util, argon2, aspell, autoconf, curl, freetds, gd, gettext, gmp, icu4c, krb5, libpq, libsodium, libzip, oniguruma, openldap, openssl@1.1, pcre2, sqlite, tidy-html5, unixodbc ==> Options --HEAD Install HEAD version ==> Caveats To enable PHP in Apache add the following to httpd.conf and restart Apache: LoadModule php_module /opt/homebrew/opt/php/lib/httpd/modules/libphp.so
SetHandler application/x-httpd-php
Finally, check DirectoryIndex includes index.php
DirectoryIndex index.php index.html
The php.ini and php-fpm.ini file can be found in:
/opt/homebrew/etc/php/8.2/
To start php now and restart at login:
brew services start php
==> Analytics
install: 16,191 (30 days), 311,161 (90 days), 1,416,631 (365 days)
install-on-request: 14,342 (30 days), 275,954 (90 days), 1,232,465 (365 days)
build-error: 0 (30 days)brew info openssl
openssl version -a
openssl ciphers
sudo nginx -t
which -a php-fpm
/opt/homebrew/opt/php/sbin/php-fpm -v
PHP 8.2.3 (fpm-fcgi) (built: Feb 15 2023 00:58:04) Copyright (c) The PHP Group Zend Engine v4.2.3, Copyright (c) Zend Technologies with Zend OPcache v8.2.3, Copyright (c), by Zend Technologiessudo /opt/homebrew/opt/php/sbin/php-fpm -y /opt/homebrew/etc/php/8.2/php-fpm.conf --test
ls -al ~/Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchDaemons | grep homebrew
ls -al /Library/LaunchDaemons | grep "com.laravel.valet."
ls -aln /etc/resolv.conf
cat /etc/resolv.conf
ifconfig lo0
sh -c 'echo "------\n/opt/homebrew/etc/nginx/valet/valet.conf\n---\n"; cat /opt/homebrew/etc/nginx/valet/valet.conf | grep -n "# valet loopback"; echo "\n------\n"'
sh -c 'for file in ~/.config/valet/dnsmasq.d/*; do echo "------\n~/.config/valet/dnsmasq.d/$(basename $file)\n---\n"; cat $file; echo "\n------\n"; done'