search

laravel / valet

A more enjoyable local development experience for Mac.
https://laravel.com/docs/valet
MIT License
2.51k stars 695 forks source link

Shopware 5 and Shopware 6 support #1424

Closed christopherholst closed 1 year ago

christopherholst commented 1 year ago

Description

This pull request introduces support for Shopware 5 and Shopware 6, popular open-source eCommerce platforms used worldwide. By adding this feature, we aim to enhance Laravel's Valet capabilities in the eCommerce domain and provide more flexibility and convenience for our users working with these platforms.

Benefits to end users

With this new support, Laravel Valet users who are also using Shopware 5 or Shopware 6 can easily integrate their eCommerce platform with their Laravel Valet applications, allowing for more seamless data flow and operation management.

Compatibility with existing features

This addition does not break any existing features of Laravel Valet. All current functionalities and features remain intact. The Shopware support is provided as an additional feature that users can opt to use if needed.

How it makes building web applications easier

Supporting Shopware 5 and Shopware 6 will make it easier for developers to build eCommerce applications using Laravel Valet. This can help streamline the development process and reduce the complexity involved in building eCommerce applications.

Tests

Instead of running formal unit tests, we have directly tested these new drivers locally on a Shopware 5.7.x system and Shopware 6.4.x system to verify their functionality and reliability. These real-world tests have given us confidence in the compatibility.

We are eager for your feedback on these enhancements. If everything is in order.

Best regards Ümit and Christopher from SYNERGY NETWORKS GmbH

allrude commented 1 year ago

HI @christopherholst, i use this Shopware 6 - Laravel Valet Custom Driver, at the moment, can you explain the advantage of your version

driesvints commented 1 year ago

Thank you for your PR. However, right now we're not accepting new drivers. You can create your own custom driver if you wish: https://laravel.com/docs/10.x/valet#custom-valet-drivers

drbyte commented 1 year ago

@christopherholst If you're willing to maintain the proposed Valet Driver, here's an option:

  1. Create a github repo for it, with naming convention of FooValetDriver (eg: ends in 'ValetDriver')
  2. See example: https://github.com/DCzajkowski/DistValetDriver
  3. In the README provide installation instructions (replacing YOU and Foo for yours of course): git clone https://github.com/YOU/FooValetDriver.git ~/.config/valet/Drivers
  4. Anytime someone wants to update their local driver from your git, they can run git pull from within that cloned directory. (You could explain that in your README as well)