search

laravel / valet

A more enjoyable local development experience for Mac.
https://laravel.com/docs/valet
MIT License
2.49k stars 691 forks source link

Only delete DNSMasq resolver when Herd is not installed #1434

Closed mpociot closed 11 months ago

mpociot commented 11 months ago

This PR ensures that the DNSMasq resolver configuration file only gets deleted when Laravel Herd is not installed. Right now this introduces a bug when a user:

  1. Installs Herd
  2. Uninstalls Valet

As Valet then deletes the DNSMasq resolver that Herd still uses.

drbyte commented 11 months ago

Looks good to me. 👍

RobertBoes commented 11 months ago

Shouldn't Herd just create the file if it doesn't exist and needs it?