Update "fetch-share-url" to pull correct URL for HTTPS tunnels, not just HTTP

laravel / valet

A more enjoyable local development experience for Mac.

https://laravel.com/docs/valet

MIT License

2.49k stars 691 forks source link

Update "fetch-share-url" to pull correct URL for HTTPS tunnels, not just HTTP #1460

Closed rana01645 closed 6 months ago

rana01645 commented 7 months ago

Every time I'm using valet fetch-share-url it's giving this error

There is no Ngrok tunnel established for ***********.test

During deep diving, I found that my tunnel is using HTTPS protocol which is why it's unable to get the shared URL!

This pull request will solve this issue!

mattstauffer commented 6 months ago

@rana01645 This is very helpful!

Do you know why you're getting an HTTPS tunnel instead of HTTP, by chance?

mattstauffer commented 6 months ago

To be honest, I don't know why we want the HTTP version locally, but I've run into this problem before too, so I'm going to merge it with a hope and a prayer that there's nothing bad about pulling in the HTTPS version when that's all we have.

rana01645 commented 6 months ago

@mattstauffer I also don't know why I'm getting only the HTTPS, we use fetch-share-url to automate the local dev setup using a bash command, and suddenly the automation fails due to this error!

It could be something related to ngrok maybe!

Thanks for merging this pull request.