Allow renew() to be called without parameters

laravel / valet

A more enjoyable local development experience for Mac.

https://laravel.com/docs/valet

MIT License

2.49k stars 691 forks source link

Allow renew() to be called without parameters #1465

Closed drbyte closed 6 months ago

drbyte commented 6 months ago

A reasonable default is set here, consistent with the default set in other places.

Fixes #1464 Updates #1461

@driesvints Can you review and consider releasing a patch, since this is a breaking bug that occurs on valet install (which people run not only to install Valet, but also after upgrading it)

einardivision commented 6 months ago

Just manually patched my file, can confirm this resolves the error:

Fatal error: Uncaught ArgumentCountError: Too few arguments to function Valet\Site::renew(), 0 passed in /Users/einarb/.composer/vendor/laravel/valet/cli/includes/facades.php on line 22 and exactly 1 expected in /Users/einarb/.composer/vendor/laravel/valet/cli/Valet/Site.php:506

Thank you!

driesvints commented 6 months ago

Thanks! Will release this.