Fix extra parameters for share tool, fixes #1494

laravel / valet

A more enjoyable local development experience for Mac.

https://laravel.com/docs/valet

MIT License

2.52k stars 698 forks source link

Fix extra parameters for share tool, fixes #1494 #1495

Open rcknr opened 2 months ago

rcknr commented 2 months ago

There was a typo in my previous PR that led to a problem passing extra arguments to share tools. Fixes #1494

drbyte commented 2 months ago

Yes, that seems to be the right fix. /cc @mattstauffer

drbyte commented 2 months ago

@rcknr Can you edit your post above, and change See #1494 to Fixes #1494. That way Github will automatically close the related issue when this PR is merged (it uses the words "fixed" or "fix" or "fixes", or "closes", in the original PR post, to automatically trigger that).

kiritokatklian commented 2 weeks ago

Any updates on when we can expect this to be merged? 😄

drbyte commented 2 weeks ago

//cc @mattstauffer