search

laravel / valet

A more enjoyable local development experience for Mac.
https://laravel.com/docs/valet
MIT License
2.52k stars 698 forks source link

Add support for PHP 8.4 #1499

Closed SupianIDz closed 2 days ago

SupianIDz commented 1 week ago

Include PHP 8.4 in the list of supported PHP versions in both Valet Brew and GitHub Actions test matrix. This ensures compatibility and testing for the latest PHP release.

This fixes the Unable to determine linked PHP when parsing '8.4' issue when using Valet using PHP version 8.4

Screenshot 2024-11-17 at 20 54 10
drbyte commented 1 week ago

Agreed.

We can update the LATEST_PHP_VERSION constant below it after 8.4 is officially released.

/cc @mattstauffer

SupianIDz commented 6 days ago

PHP 8.4 is out now, so when will this be merged?

cc @mattstauffer

drbyte commented 4 days ago

NOTE: As a temporary workaround, you can edit your ~/.composer/vendor/laravel/valet/cli/Valet/Brew.php and add PHP 8.4 to the top of the supported-versions array.

Later, after this is merged, you can remove the edit. Or when you run composer global update it will ask you if you want to "stash" or "replace" your edits. Choose "Replace" (or whatever means to delete your temporary edits).

RobertBoes commented 2 days ago

@mattstauffer @taylorotwell could this get a review? Herd had support for 8.4 alpha for ages, while also being built on top of Valet. Now that 8.4 is released it would be nice to have support for it in Valet, so people can test and upgrade.

mattstauffer commented 2 days ago

@SupianIDz Thanks for the PR! Apologies for the delay, my GitHub inbox is an absolute garbage fire so a week is actually a pretty fast turnaround for me these days :)

@drbyte thanks as always for the review! And the workaround suggestion for folks.

@RobertBoes Herd was based on Valet, but does not contribute back to Valet. You can expect features and timelines to differ between the two.

Herd is a paid project, maintained by people paid to work on it. Valet is free, maintained by volunteers--mainly @drbyte and me, and also some other wonderful people who take their time to submit and review PRs.

As I mentioned above, I wish I had gotten to this one faster. But comparing Valet and Herd is not going to be a productive strategy. :)

RobertBoes commented 1 day ago

@mattstauffer Right, that makes sense, sorry I worded it a bit shitty 😅

Thanks for the clarification, I was under the impression it just used Valet (since that's present in the binary file of Herd) and Valet contains a bit of code to account for Herd.