laravel / valet

A more enjoyable local development experience for Mac.

https://laravel.com/docs/valet

MIT License

2.52k stars 698 forks source link

Valet status command #251

Closed welcoMattic closed 6 years ago

welcoMattic commented 7 years ago

It would be nice to have a valet status command, to know if valet is currently started or stopped. With this kind of command we could call it from any menu-bar software like BitBar, and get a visual indication of valet status.

shiroamada commented 7 years ago

valet start also not really indicate nginx is really start. I got wrong config file setup in /Users/shiroamada/.valet/Nginx/mywebsite.dev, but valet start still show it successfully started. But actually my nginx is not started. I need to sudo nginx to check what's really goes wrong.

antonioribeiro commented 7 years ago

@shiroamada, sent a PR to fix your issue: https://github.com/laravel/valet/pull/268

lukeed commented 7 years ago

17

omdjinmesem commented 7 years ago

It this command valet status already implemented yet? I cant findstatus on the command list

drbyte commented 6 years ago

It this command valet status already implemented yet?

No, however, valet is more verbose about errors occurring when re/starting nginx.

Nowadays you can run: brew services list to get a status.

mattstauffer commented 6 years ago

Closing; if this is re-suggested given the current state of things we can start a new discussion.

audetcameron commented 3 years ago

It this command valet status already implemented yet?

No, however, valet is more verbose about errors occurring when re/starting nginx.

Nowadays you can run: brew services list to get a status.

what if brew services list shows nothing is running (but valet is running and working) is there some sort of permission disconnect or something that is going on? I confirmed my foo.test site is running but nginx and PHP show as stopped

mayrac2022 commented 1 year ago

I think it would be really nice to have this command. brew services list doesn't explicitly say Valet, so we have to figure it out.

mattstauffer commented 1 year ago

I'm considering adding this command to v4.

Here's what I'm thinking.

Valet isn't ever actually "running" or "not running". But, it can have a boolean type status: it can be "configured correctly with all its services running" or "something is wrong, whether a service not running, a configuration error, or Valet not installed at all".

Would that be helpful?

If so, I'm imagining it would check:

Is Valet installed
Are all services (Nginx, Dnsmasq, etc.) running via Brew
Are all configuration items non-erroring (e.g. check the Nginx config, manually check our local Valet config files, etc.)

If so, it would return a positive return code, together with some nice graphics showing success.

If not, it would return a negative return code, together with the same graphics showing errors.

philbraun commented 1 year ago

Having a valet status sommand would be really nice, especially if the output is less confusing than brew services list. (Here's what this looks like here; Valet is running without any problems even before valet start, doing the full composer global update > valet install doesn't change anything to these outputs)