vesper8
commented
7 years ago This is driving me mad.. been trying to fix it for hours
I tried the solution in this gist https://gist.github.com/milesw/832ffe73c1e9ff3af81f5148f8e0ee45
<?php
class StaticCorsValetDriver extends BasicValetDriver
{
/**
* Determine if the driver serves the request.
*
* @param string $sitePath
* @param string $siteName
* @param string $uri
* @return bool
*/
public function serves($sitePath, $siteName, $uri)
{
if (file_exists($sitePath . '/index.php') && file_exists($sitePath . '/cdn_mirror.php')) {
if (0) {
echo "<pre>" . print_r($sitePath, true) . "</pre>";
echo "<pre>" . print_r($siteName, true) . "</pre>";
echo "<pre>" . print_r($uri, true) . "</pre>";
var_dump($this->isStaticFile($sitePath, $siteName, $uri));
die();
}
return $this->isStaticFile($sitePath, $siteName, $uri);
}
}
/**
* Determine if the incoming request is for a static file.
*
* @param string $sitePath
* @param string $siteName
* @param string $uri
* @return string|false
*/
public function serveStaticFile($staticFilePath, $sitePath, $siteName, $uri)
{
//die("123");
if (1) {
header('Access-Control-Allow-Origin: *');
} else {
if (isset($_SERVER['HTTP_ORIGIN'])) {
//header("Access-Control-Allow-Origin: {$_SERVER['HTTP_ORIGIN']}");
header("Access-Control-Allow-Origin: *");
header('Access-Control-Allow-Credentials: true');
header("Access-Control-Allow-Methods: GET, POST, OPTIONS");
}
if ($_SERVER['REQUEST_METHOD'] == 'OPTIONS') {
if (isset($_SERVER['HTTP_ACCESS_CONTROL_REQUEST_METHOD']))
header("Access-Control-Allow-Methods: GET, POST, OPTIONS");
if (isset($_SERVER['HTTP_ACCESS_CONTROL_REQUEST_HEADERS']))
header("Access-Control-Allow-Headers:{$_SERVER['HTTP_ACCESS_CONTROL_REQUEST_HEADERS']}");
exit(0);
}
}
parent::serveStaticFile($staticFilePath, $sitePath, $siteName, $uri);
}
}I can confirm that my requests to the static files (fonts) are going through my custom driver.. yet the CORS is not being applied.
It's not being applied in Chrome, but also not showing when I use the command line and do a curl -I
The files are reachable and if I point my browser to the full url (of the font files) then it does immediately download without issue.
Since all of these sites use the valet secure flag, which generates a nginx configuration for each of those sites, I have also tried adding the CORS inside the nginx configs. But that too is not helping at all
I tried adding
location / {
if ($request_uri ~* ^.*?\.(eot|ttf|woff|woff2)$) {
add_header Access-Control-Allow-Origin *;
}
rewrite ^ /Users/vesperknight/.composer/vendor/laravel/valet/server.php last;
}Would really appreciate some hint
adamwathan
drbyte
BSN4
poul-kg
vwasteels
I know that "CORS is usually handled at the app level" however I have a scenario here where I want to load css/js from a dev domain that is served by valet. However the domain "https//assets.mydomain.dev" ONLY has css/js/images and does not implement any kind of php where I would normally be setting CORS rules.
The only way to achieve this that I can think of is to add CORS whitelisting in the nginx configuration for that specific website (although I would be happy to categorically whitelist everything for cors since this is a dev environment)
Any way to achieve this with Valet?