laravel / vite-plugin

Laravel plugin for Vite.
MIT License
804 stars 152 forks source link

Fix types for moduleResolution=nodenext/bundler #258

Closed sapphi-red closed 11 months ago

sapphi-red commented 1 year ago

The types condition was wrongly declared. https://arethetypeswrong.github.io/?p=laravel-vite-plugin%400.8.1

This PR fixes that by

timacdonald commented 11 months ago

Thanks again for your help here, @sapphi-red.

We've got a working branch where I think we have the types already sorted, but I'll double check against that tool once we have our final state.

I'm going to close this one as we I'm creating a single PR to house all our Vite 5 upgrade work to make it easier for review etc.

Thanks again. We really appreciate the Vite team ❤️