laravel / vite-plugin

Laravel plugin for Vite.
MIT License
804 stars 152 forks source link

Vite 5 Support #265

Closed driesvints closed 10 months ago

driesvints commented 11 months ago

We're working on Vite 5 support which is most likely to arrive somewhere next week.

driesvints commented 11 months ago

Relevant: https://github.com/laravel/framework/pull/49049

Unnoen commented 11 months ago

Just copying this comment from https://github.com/laravel/framework/pull/49049#issuecomment-1819174930 by @gabrielrbarbosa for a simple fix.

I solved this by just editing vite.config.js, I think it may be easier to just add:

export default defineConfig({
  build: {
    manifest: 'manifest.json',
  },
});

The above is working for me with no noticeable issues.

taylorotwell commented 11 months ago

We will get to this after Pulse is released this week.

craigrileyuk commented 11 months ago

@Unnoen

This works pretty well, but I'm getting a The "code" argument must be of type number. Received type string ('SIGINT') error when I exit dev mode, so it's not a perfect workaround.

AntonOfTheWoods commented 11 months ago

I agree it works "pretty well". Is there a list of things that need work?

xsjcTony commented 11 months ago

Any progress on this? Vitest released v1 and it requires vite v5 to work😥

indy2kro commented 11 months ago

The "somewhere next week" passed about 1 week ago, any idea when this could be released?

m4nug commented 11 months ago

The "somewhere next week" passed about 1 week ago, any idea when this could be released?

taylorotwell commented last week We will get to this after Pulse is released this week.

How can you write code if you can not even read?

leknoppix commented 11 months ago

The "somewhere next week" passed about 1 week ago, any idea when this could be released?

Certainly, the announcement of a new release compatible with vite 5 was announced a little too far in advance, but hey, I think that the developers don't just have that to do and deserve encouragement. If you're in such a hurry, just modify the current code to make it evolve and submit a pull request to them. This plugin is free, so, for my part, I don't really like this kind of remark.

Good luck to the developers.

gabrielrbarbosa commented 11 months ago

@leknoppix To be honest, I've opened the first issue #253 two months ago when Vite 5.0 was in beta and it was already marked for release this quarter, also @driesvints just closed many issues as completed when people started to use stable version...

So for now I'm just using workarounds and added --legacy-peer-deps to npm install and waiting :)

driesvints commented 11 months ago

Hi all. We realise everyone wants Vite 5 support as soon as possible. We're doing the best we can with the resources we have and with other work also in mind. Keep an eye on our twitter to know when it's out.

taylorotwell commented 11 months ago

Plan is to start on Vite 5 support next week. 🤘

taylorotwell commented 10 months ago

Releasing today.