search

laravel / vonage-notification-channel

Vonage Notification Channel for Laravel.
https://laravel.com/docs/notifications#sms-notifications
MIT License
744 stars 51 forks source link

[2.0] Fix shortcode implementation and test coverage #26

Closed dwightwatson closed 5 years ago

dwightwatson commented 5 years ago

I found a really silly bug in the shortcode channel (sorry) that assigned the argument to the wrong instance variable. It seems the test coverage didn't pick it up as Mockery didn't specify the number of times each mock should be called.

I've updated the mocks to ensure that they are called once as expected, and also implemented routeNotificationFor* methods in the stub notifiables so the tests are actually performed to completion.