search

laravel / vonage-notification-channel

Vonage Notification Channel for Laravel.
https://laravel.com/docs/notifications#sms-notifications
MIT License
744 stars 51 forks source link

Fix Notification service resolution in provider #5

Closed mpyw closed 5 years ago

mpyw commented 5 years ago

ChannelManager should be resolved not in register() but in boot(). It will break application bootstrap if ChannelManager is extended and the original Illuminate\Notifications\NotificationServiceProvider is replaced by extended App\Providers\NotificationServiceProvider.

Unresolvable dependency resolving [Parameter #0 [ <required> $app ]] in class Illuminate\Support\Manager

Related: https://github.com/laravel/slack-notification-channel/pull/10

driesvints commented 5 years ago

Please see https://github.com/laravel/framework/issues/26766 & https://github.com/laravel/nexmo-notification-channel/issues/2

mpyw commented 5 years ago

Discussion: https://github.com/laravel/slack-notification-channel/pull/10

mpyw commented 5 years ago

Related: [5.8] Use Facade::resolved() before extending channel by crynobone · Pull Request #4 · laravel/nexmo-notification-channel

@taylorotwell Could you also merge it to 5.7?