Closed SecondeJK closed 1 year ago
Lgtm. @potsky @ankurk91 @Brenneisen would any of you be able to try this one out before we merge it?
Sure, tomorrow, my morning 👍
I'll need to do a minor version bump tomorrow morning GMT to squash a bug.
Version bump done.
Working fine for me.
Sorry I'm coming after the war but it's good for me too.
@SecondeJK just a feedback : I have no PHP warning if I add the char ç in the message text and ç is not in the default GSM charset.
The message sent with the text
type is only in one part and the ç is replace by ? in the received SMS message which is really ok for me.
This PR is a redone version of the previously merged #61, which was reverted because v4.0 of the Vonage Core SDK was not being pulled in. Subsequently, messages were defaulted to Unicode for encoding, resulting in more SMS deliveries to end devices.
This PR now pulls in 4.0.4 of the SDK which does the following:
sms()
client instead of the legacymessage()
client.text
which is GSM-7 encodedunicode()
method to switch if needs beE_USER_WARNING
but no exception, advising you to use the preferred encoding typeE_USER_WARNING
advising you that the end device is likely to have scrambled characters due to not using the preferred encoding type.For users, if you are not sure of the encoding type for your Notification message, a static helper method is now available for you to check before sending the notification through the channel.
\Vonage\SMS\Message\SMS::isGsm7($message);
Vonage are committed to users and to Laravel itself to make the best developer experience possible. If there are questions or concerns, hit me up.