search

laravelista / comments

Native comments for your Laravel application.
MIT License
745 stars 144 forks source link

Please add: Confirmation before deleting comments. #107

Open preimpression opened 4 years ago

preimpression commented 4 years ago

Most websites where you can comment and delete your comment have a dialog to request confirmation before deleting a comment. I think that should be added to the standard package.

mabasic commented 4 years ago

This would require some JS which I have avoided adding to this package, but maybe I could add a bootstrap modal or a simple js implementation.

preimpression commented 4 years ago

Thanks for replying!

I think we ended up going for the bootstrap modal route - when I was attempting with methods such as confirm(), my site had a conniption and I ended up putting my attempts at fiddling with the package on pause.

A friend (I mentioned on the new permalinking Issue) picked up the package managed to get the confirmation modal working :)

mabasic commented 3 years ago

Note to self: This could be implemented the same as I implemented editing of comments, but I would make this opt-in functionality.