search

laravelista / comments

Native comments for your Laravel application.
MIT License
745 stars 144 forks source link

Support Laravel 8 #117

Closed Vendin closed 3 years ago

mabasic commented 4 years ago

@prof-usman @Vendin Have you tested the package with these changes in a Laravel 8 app?

My biggest concern is that they have made some changes in Laravel 8 which will reflect negatively in this package. Also, if there are changes needed for Laravel 8, then I have to decide if I want to push a major or minor version.

I don't want to release support for Laravel 8 if the package is untested. What I usually do is create a new Laravel x (8) app, install this package following the readme and confirm that each feature works.

Since I don't have the time to do that currently, if you have already done this and confirmed that it works I will merge this PR and publish a new version.

mabasic commented 3 years ago

@rikvermeulen @prof-usman @Vendin Great stuff guys! You have approved this PR without testing if it works. It does not work because you did not upgrade spatie/laravel-honeypot which causes installation errors.