laravelista / comments

Native comments for your Laravel application.
MIT License
745 stars 144 forks source link

Package changes default the behaviour of Paginator to use Bootstrap Templates #139

Closed papoms closed 3 years ago

papoms commented 3 years ago

Laravel 8.0 defaults to Tailwind views for the Paginator [1].

This package calls Paginator::useBootstrap(); in the boot() Method. This changes the Paginator behaviour globally and breaks pagination in a tailwind based Project.

Maybe we can add a setting in the config to disable it?

[1] https://laravel.com/docs/8.x/pagination#using-bootstrap

mabasic commented 3 years ago

I have completely forgotten about Tailwind in Laravel 8.

The views for this package should also be updated to match Tailwind (the default ui for laravel views). I would ideally like to keep the Bootstrap views and provide a config option for that too. Need to think about this.

papoms commented 3 years ago

The views for this package should also be updated to match Tailwind (the default ui for laravel views). I would ideally like to keep the Bootstrap views and provide a config option for that too. Need to think about this.

i just adapted the views in a tailwind based project (Jetstream / Livewire with Alpine.js to be specific).

Imho The big difference is that bootstrap comes with a default for modals while Tailwind does not. So i am not sure what kind of implementation would be the common ground here. E.g. i just used pure blade with some alpine.js to make the views work while someone else might want to use Livewire / vuejs.

mabasic commented 3 years ago

A new release will probably be built with Tailwind.

simonepozzobon commented 2 years ago

A new release will probably be built with Tailwind.

Any news about this?

mabasic commented 2 years ago

A new release will probably be built with Tailwind.

Any news about this?

Nothing yet. I've been working with Tailwind and Laravel Livewire lately so I'm getting accustomed to it. Can't exactly tell in which direction this should go. Maybe blade components with a bit of alpine.js or something like that...

m7vm7v commented 2 years ago

Any chance anyone here has any example for using it with livewire, alpinejs and tailwind? It will be great if you could share as many are eager for it. I am thinking of making this but if there is someone with that combo please share.