mabasic
commented
3 years ago To have support for Laravel 8, you must have php 7.4 installed.
Closed whakru closed 3 years ago
mabasic
commented
3 years ago To have support for Laravel 8, you must have php 7.4 installed.
whakru
commented
3 years ago To have support for Laravel 8, you must have php 7.4 installed.
I updated php to 8.0 and I updated composer to 2
Using version ^1.1 for laravelista/comments
./composer.json has been updated
Running composer update laravelista/comments
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
Problem 1
- laravelista/comments[1.1.0, ..., 1.1.2] require illuminate/support ^5.2 -> found illuminate/support[v5.2.0, ..., 5.8.x-dev] but these were not loaded, likely because it conflicts with another require.
- Root composer.json requires laravelista/comments ^1.1 -> satisfiable by laravelista/comments[1.1.0, 1.1.1, 1.1.2].
Installation failed, reverting ./composer.json and ./composer.lock to their original content.composer.json :
{
"name": "laravel/laravel",
"type": "project",
"description": "The Laravel Framework.",
"keywords": [
"framework",
"laravel"
],
"license": "MIT",
"require": {
"php": "^7.3|^8.0",
"fideloper/proxy": "^4.4",
"fruitcake/laravel-cors": "^2.0",
"guzzlehttp/guzzle": "^7.0.1",
"laravel/framework": "^8.12",
"laravel/tinker": "^2.5",
"predis/predis": "^1.1",
"socialiteproviders/facebook": "^4.1",
"socialiteproviders/google": "^4.1",
"socialiteproviders/instagram": "^4.1",
"socialiteproviders/instagram-basic": "^4.1",
"socialiteproviders/odnoklassniki": "^4.1",
"socialiteproviders/vkontakte": "^4.2",
"illuminate/support": "^8.2"
},
"require-dev": {
"facade/ignition": "^2.5",
"fakerphp/faker": "^1.9.1",
"laravel/sail": "^1.0.1",
"mockery/mockery": "^1.4.2",
"nunomaduro/collision": "^5.0",
"phpunit/phpunit": "^9.3.3"
},
"config": {
"optimize-autoloader": true,
"preferred-install": "dist",
"sort-packages": true
},
"extra": {
"laravel": {
"dont-discover": []
}
},
"autoload": {
"psr-4": {
"App\\": "app/",
"Database\\Factories\\": "database/factories/",
"Database\\Seeders\\": "database/seeders/"
}
},
"autoload-dev": {
"psr-4": {
"Tests\\": "tests/"
}
},
"minimum-stability": "dev",
"prefer-stable": true,
"scripts": {
"post-autoload-dump": [
"Illuminate\\Foundation\\ComposerScripts::postAutoloadDump",
"@php artisan package:discover --ansi"
],
"post-root-package-install": [
"@php -r \"file_exists('.env') || copy('.env.example', '.env');\""
],
"post-create-project-cmd": [
"@php artisan key:generate --ansi"
]
}
}I tried deleting it "illuminate/support" Update and so on... But I always get the same error as far as I know, the illuminate/support package is already included by default in laravel. and you don't need to set it to "composer.json". let me remind you that deleting the line "illuminate/support": "^8.2 " does not give anything.. Sorry for the bad English...
mabasic
commented
3 years ago This package only supports Laravel 8 and PHP 7.4 for now. I will have to update it for PHP 8.
I'm kind of busy lately to review the code myself, but If you want you can send a PR with support for PHP8 when you verify that it actually works with PHP8.
whakru
commented
3 years ago This package only supports Laravel 8 and PHP 7.4 for now. I will have to update it for PHP 8.
I'm kind of busy lately to review the code myself, but If you want you can send a PR with support for PHP8 when you verify that it actually works with PHP8.
I deleted it "illuminate/support": "^8.0", https://github.com/whakru/comments/commit/90b512827375a74d5e970f0b7cc983cfc9c94b6c#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34 and change "php": "^8.0", (He also swore at the version.) https://github.com/whakru/comments/commit/5789f6c9d86899c57101b8c37576a889241a15b4#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34
Sorry, I don't know how to suggest edits. But it works for me without any problems.
mabasic
commented
3 years ago Nice to know that it works.
run composer require laravelista/comments get an error:
composer.json :
PHP 7.3 latest version of laravel