search

laravelista / comments

Native comments for your Laravel application.
MIT License
744 stars 142 forks source link

Comments are deleted with commentable type no matter what #168

Open nickclickmyads opened 3 years ago

nickclickmyads commented 3 years ago

I was using comments for models with SoftDeleted, whenever any model gets soft deleted all its comments are wiped out. I was very surprised that there was this code all the time. Such thing should be noted in configuration file. https://github.com/laravelista/comments/blob/f1c7a476f79b80f0e28ba901436832f773299ee6/src/Commentable.php#L18-L25

mabasic commented 3 years ago

When a comment is soft deleted all of its related comments should also be soft deleted. Is this not the case?

aafaq146 commented 2 years ago

is there any way to embed js in your package?and we xcan mention someone in your package or not??

mabasic commented 2 years ago

is there any way to embed js in your package?and we xcan mention someone in your package or not??

Your question is not related to this issue, but to answer it: you can modify every bit of my package by customizing it. See the readme for details. You can publish views, modify policies, change migrations, change routes, controllers and models. But at that point you can write it for yourself.