search

laravelista / comments

Native comments for your Laravel application.
MIT License
744 stars 142 forks source link

Not compatible with Laravel 10.X , unable to install #201

Open akhilkharva opened 10 months ago

akhilkharva commented 10 months ago

Issue: I am using the Laravel v10.10 version and tried to install this package, but seems like its dependency is not updated/supported by the latest version, can you please update it? I have mentioned the full error block over here. ----------------Error returned on : composer require laravelista/comments ------------------------ 

Using version ^4.5 for laravelista/comments
./composer.json has been updated
Running composer update laravelista/comments
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires laravelista/comments ^4.5 -> satisfiable by laravelista/comments[4.5.0].
    - laravelista/comments 4.5.0 requires illuminate/database ^8.0 -> found illuminate/database[v8.0.0, ..., v8.83.27] but these were not loaded, likely because it conflicts with another require.

You can also try re-running composer require with an explicit version constraint, e.g. "composer require laravelista/comments:*" to figure out if any version is installable, or "composer require laravelista/comments:^2.1" if you
 know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

----------------**Error returned on : composer require laravelista/comments:*** ------------------------ 

 composer require laravelista/comments:*
./composer.json has been updated
Running composer update laravelista/comments
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - laravelista/comments[1.0.0, ..., 1.1.2] require illuminate/support ^5.2 -> found illuminate/support[v5.2.0, ..., v5.8.36] but these were not loaded, likely because it conflicts with another require.
    - laravelista/comments[2.0.0, ..., 2.0.1] require php 7.2.* -> your php version (8.1.10) does not satisfy that requirement.
    - laravelista/comments[2.0.2, ..., 2.1.0, 3.0.0, ..., 3.4.2] require php ^7.1.3 -> your php version (8.1.10) does not satisfy that requirement.
    - laravelista/comments[3.5.0, ..., 3.6.1] require php ^7.2.5 -> your php version (8.1.10) does not satisfy that requirement.
    - laravelista/comments[4.0.0, ..., 4.4.1] require php ^7.4 -> your php version (8.1.10) does not satisfy that requirement.
    - laravelista/comments 4.5.0 requires illuminate/database ^8.0 -> found illuminate/database[v8.0.0, ..., v8.83.27] but these were not loaded, likely because it conflicts with another require.
    - Root composer.json requires laravelista/comments * -> satisfiable by laravelista/comments[1.0.0, 1.1.0, 1.1.1, 1.1.2, 2.0.0, ..., 2.1.0, 3.0.0, ..., 3.6.1, 4.0.0, ..., 4.5.0].

Installation failed, reverting ./composer.json and ./composer.lock to their original content.
robbielove commented 6 months ago

https://github.com/laravelista/comments/issues/200#issuecomment-1596710162

There is no Laravel 9 & 10 compatibility because I haven't found the time to test it and I haven't got a need to do it also. If you want, you can always send a PR which isn't just bumping dependencies but also creating a sample repository and checking the functionality of the package ...

The testing process is very difficult and I don't want to release something that isn't tested. Currently there are no tests for this package. That is one of the things that I would like to do ... but again, haven't had the time or the need for it.