larcenists / larceny

Larceny Scheme implementation
Other
202 stars 32 forks source link

fxreverse-fixnum error in self call #787

Open ghost opened 7 years ago

ghost commented 7 years ago

In r6rs/arithmetic/fixnums.body.scm there is an error on line 449, in the function fxreverse-fixnum:

(+ 1 (fxreverse-fixnum (- fx (least-fixnum))))

There should be a second parameter in the call to fxreverse-fixnum.

Should the line be: (+ 1 (fxreverse-fixnum (- fx (least-fixnum)) k))

WillClinger commented 7 years ago

Thank you.

This is in tools/R6RS/r6rs/arithmetic/fixnums.body.scm

Fixed in changeset 52d391e302c292c0a5f56a3db6958a7ce5fc1e27

I'm leaving this open for now because the fix needs to be tested further and pushed to Snow.

WillClinger commented 7 years ago

Changing the milestone because v1.3 doesn't need to wait on this.

WillClinger commented 7 years ago

I intended only to change the milestone, not to close the issue.