lardbit / nefarious

Web application for automatically downloading TV & Movies (w/ VPN)
https://lardbit.github.io/nefarious/
GNU General Public License v3.0
1.04k stars 77 forks source link

[Feature] Manunal search for specific episodes #28

Open Kioshi opened 4 years ago

Kioshi commented 4 years ago

My apology if it is already there and I just missed it.

Manual search is great feature but right now for series is bin unintuitive since you can only search whole seasons manually.

Another thing would be allow search from the status section (You see torrent was not found for episode / series, you will try your own luck right there)

Now if I am searching for episode where torrent was not found, I would like to know why without long search in logs. So last feature suggestion for this would be catch search data returned from Jackett (could be just for 24h or something). When applying search criteria on data again user can get grasp of why torrent wasn't found and also select one of the rejected torrents without new search.

The last part is bit of a stretch that would be nice for future but definitely low priority now.

lardbit commented 4 years ago

@Kioshi, you can manually search for individual episodes. Just check the Manual checkbox and then click the magnifying class next to the episode you're interested in.

image

I agree that the TV screen should be updated to be more intuitive. I'd like to get rid of the Details and Status tabs and just merge them into a single screen.

In addition, I do want to include log details to why a particular movie/season/episode wasn't downloaded.

These are good ideas and I'll keep this issue open until I have time to tackle them.

Kioshi commented 4 years ago

Oh, for some reason I got a magnifying glass only at season for some serie, but I can not find which one now I will report back if it happens again.

Kioshi commented 4 years ago

Ok I have found the series that causes issues, and its not only manual search. The searies name "Shameless" Issues:

  1. When searching for Shameless only US version is found
  2. When downloaded it is put into folder Shameless, not Shameless (US) which confuses Jellyfin
  3. When trying manual search I only see magnifying glass for whole season

shameless

I am not sure which indexer is used in Nefarious but tvdb have both correctly named https://www.thetvdb.com/series/shameless https://thetvdb.com/series/shameless-us

Also for Anime "The Seven Deadly Sins" I ended up with this tv/The Seven Deadly Sins/

Kioshi commented 4 years ago

Also one more thing, once torrent is searched manualy and selected it is not possible to research it even after canceling retrieving.

lardbit commented 4 years ago

When searching for Shameless only US version is found

When I search shameless in nefarious I see two results: The US and the british (I think, from 2004). I'm using The Movie Database as the metadata service and you can see it's results here: https://www.themoviedb.org/search/tv?query=Shameless&language=en-US

When downloaded it is put into folder Shameless, not Shameless (US) which confuses Jellyfin

I agree that it's a conflict for duplicate named TV Shows and I don't have a solution for it at the moment. Would we want to append the country it came from for every TV Show? Or maybe just the year it was released? Like Shameless (2004)?

When trying manual search I only see magnifying glass for whole season

This is sort of an unintuitive interface issue. The magnifying glass only appears if you're not already watching that episode. For example, uncheck an episode, click "Watch selected episodes" and then you'll see the magnifying glass appear. I designed it like that since it didn't make sense to manually search for something when you wanted it automatically downloaded.

Also for Anime "The Seven Deadly Sins" I ended up with this tv/The Seven Deadly Sins/ Season 01/ -- Season 1/ --- episodes... -- Season 2/ --- episodes... -- Specials/ --- episodes... Season 02/

This is probably nefarious's fault. It asks transmission to move the torrent data to a properly named directory (i.e "The Seven Deadly Sins/Season 01/"), but if the torrent is already in a nested sub-folder then nefarious doesn't have the ability to change that folder structure. Basically, it's at the mercy of transmission and what it's API offers. This is unfortunate but the only solution would mean I'd have to swap transmission out for another, more advanced, torrent client like qBittorrent. Does jellyfin not recognize that nested folder structure?

lardbit commented 4 years ago

Also one more thing, once torrent is searched manualy and selected it is not possible to research it even after canceling retrieving.

I wasn't able to reproduce that. I manually searched and selected Shameless Season 9, which got queued up in Transmission, then I clicked Stop watching season which removed the torrent and allowed me to manually search again.

Kioshi commented 4 years ago

When searching for Shameless only US version is found

When I search shameless in nefarious I see two results: The US and the british (I think, from 2004). I'm using The Movie Database as the metadata service and you can see it's results here: https://www.themoviedb.org/search/tv?query=Shameless&language=en-US

I upgraded / restarted Nefarious and I do now too, weird.

When downloaded it is put into folder Shameless, not Shameless (US) which confuses Jellyfin

I agree that it's a conflict for duplicate named TV Shows and I don't have a solution for it at the moment. Would we want to append the country it came from for every TV Show? Or maybe just the year it was released? Like Shameless (2004)?

Yes naming as Movie/Series (year) would solve this issue

When trying manual search I only see magnifying glass for whole season

This is sort of an unintuitive interface issue. The magnifying glass only appears if you're not already watching that episode. For example, uncheck an episode, click "Watch selected episodes" and then you'll see the magnifying glass appear. I designed it like that since it didn't make sense to manually search for something when you wanted it automatically downloaded.

Also one more thing, once torrent is searched manualy and selected it is not possible to research it even after canceling retrieving.

I wasn't able to reproduce that. I manually searched and selected Shameless Season 9, which got queued up in Transmission, then I clicked Stop watching season which removed the torrent and allowed me to manually search again

I think this is the same issue (can no manually search already watching episodes and when I searched one manually it is taken as already watched?).

This is probably nefarious's fault. It asks transmission to move the torrent data to a properly named directory (i.e "The Seven Deadly Sins/Season 01/"), but if the torrent is already in a nested sub-folder then nefarious doesn't have the ability to change that folder structure. Basically, it's at the mercy of transmission and what it's API offers. This is unfortunate but the only solution would mean I'd have to swap transmission out for another, more advanced, torrent client like qBittorrent. Does jellyfin not recognize that nested folder structure?

Unfortunately no, but I dont think it is important now to trying to fix it (there can be lot of mess in the downloaded directory for whole season) I would suggest

  1. Show in nefarious file list somewhere
  2. When renaming files to S01E03.mvk for example create file S01E03.name.txt with original name so matching subtitles can be found after.

Also if you will be looking to different torrents, check out Deluge

Trying to get new season of The Seven Deadly Sins lead me to also another suggestion for "Semi-manual search" :D The automatic search right now works the way it takes some parameters of the watched item lets say {name} {year of release} S{season number} E{episode number} and pass it to jackett right? If we could specify searched query based for a series / season it would make nefarious better since it would allow users to solve series specific problems / or create preference for source. One problem it would solve is Series The Seven Deadly Sins season 3 can only be found on nyaa when S3 is used not S03, if I could change only this for automatic search I wouldn't have to manually search every episode.

lardbit commented 4 years ago

Aha! I finally figured out how to move and rename individual files. That will solve the nested folder issue you brought up.

For example, to rename the png file to a bmp: (this is for my own reference)

torrent_client.rename_torrent_path(torrent.hashString, 'Ad Astra (2019)/www.YTS.LT.png', 'www.YTS.LT.bmp') 

I'm going to tackle that one first then prioritize your other suggestions.