CreateNXGraph may fail when xacro contains pattern definition

lardemua / atom

Calibration tools for multi-sensor, multi-modal robotic systems

GNU General Public License v3.0

245 stars 28 forks source link

CreateNXGraph may fail when xacro contains pattern definition #879

Closed miguelriemoliveira closed 3 months ago

miguelriemoliveira commented 3 months ago

Should check this!

https://github.com/lardemua/atom/blob/4dde2967b5d8b8ff7e24d6757530409896e1b406/atom_core/src/atom_core/config_visualization.py#L127

miguelriemoliveira commented 3 months ago

Done. @brunofavs I pushed the changes.

miguelriemoliveira commented 3 months ago

Closing this one. We decided that its better to remove the flag utf and make atom always use a mixture of the xacro and the transforms in the bagfile (#838).