lardemua / atom

Calibration tools for multi-sensor, multi-modal robotic systems
GNU General Public License v3.0
249 stars 27 forks source link

Check if there are duplicate transforms in the config.yml #895

Closed miguelriemoliveira closed 6 months ago

miguelriemoliveira commented 6 months ago

We are having all this work in the calibrate script

https://github.com/lardemua/atom/blob/27dc69a6fc8a1a35e83abec751a9a616e95f9125/atom_calibration/scripts/calibrate#L300C5-L320C85

Because of trying to solve #120

It is best to have the configure_calibration_pkg check if there are repeated transforms and, if so, abort.

miguelriemoliveira commented 6 months ago

First step is to detect if there are overlapping transforms identified to optimization during configuration, and to abort if so.

miguelriemoliveira commented 6 months ago

Configure already detects if there are duplicate transforms. Now we should simplify the calibrate script taking this into account.