search

lardemua / atom

Calibration tools for multi-sensor, multi-modal robotic systems
GNU General Public License v3.0
245 stars 28 forks source link

Move atom examples data to NAS #905

Open miguelriemoliveira opened 3 months ago

miguelriemoliveira commented 3 months ago

Hi @manuelgitgomes , @Kazadhum and @brunofavs ,

I was working on this last week. I could not find a way to create a script to automatically download data from the NAS. The implications are that the script to download the data from all atom examples at once would disapear.

For the atom team we have the solution to setup the synology drive, so that script won't be necessary, but other atom users would have to download the data piece by piece.

Do you think this is a big shortcoming, or that we may advance like this?

Kazadhum commented 3 months ago

Hello @miguelriemoliveira! I don't really think it's a big problem.

Trying to imagine being someone trying to learn how to use ATOM, which I assume is the bulk of people using the atom_examples, I think I'd go system-by-system and I'd imagine I would consult the documentation for each system anyways. So I don't really think it's such a big inconvenience to download a system at a time...

Let's see what @brunofavs and @manuelgitgomes say...

manuelgitgomes commented 3 months ago

Do you think this is a big shortcoming, or that we may advance like this?

I do not think so, and I agree with @Kazadhum.

miguelriemoliveira commented 3 months ago

On it...

brunofavs commented 3 months ago

I think all the links for the "downloadables" should be at the top of each example then, instead of spread out on the example readme, often in different places. It would be more systematic.

Another thing to take into consideration is that as is, the user won't have problems with wrong folder structure as its all predefined by the download script. But as long as we have a note here ... https://github.com/lardemua/atom/blob/b5b9574ae97d09a561767462de3434a4d6c158a9/atom_examples/README.md?plain=1#L25

... explaining how the folder structure should look it should be fine.

brunofavs commented 3 months ago

I think all the links for the "downloadables" should be at the top of each example then

Like this :

https://github.com/lardemua/atom/blob/0c678bcbc4481df99875ec2e61531756a7dbb0e9/atom_examples/softbot/README.md#L3-L8

miguelriemoliveira commented 3 months ago

Right @brunofavs ,

thank makes sense.

Thanks.