laresbernardo / lares

Analytics & Machine Learning R Sidekick
https://laresbernardo.github.io/lares/
233 stars 49 forks source link

Volume of Mutual Funds are returning 0 #10

Closed emmagriff closed 5 years ago

emmagriff commented 5 years ago

Tried my own file of MFs with Lares' dummyPortfolio format. Loaded data in correctly but when I ran get_stocks_hist volume column was set to all zeroes. When I run dfp<-stocks_objects(df), dfp returns Lares' data, not mine.

laresbernardo commented 5 years ago

Hello @emmagriff Thanks for opening this thread with your issue. I've just adjusted some functions and should be running well with your xlsx. The zeroes stuff can't be fixed by me because it is a yahoo's thing when quoting your stocks... but the logic behind it yes! Please, run devtools::install_github("laresbernardo/lares"), fully close your Rstudio, and reopen it to try again. Let me know if it ran OK? If not, please reply with your code and error messages. BTW, your Excel file is kind of weird because you invested since like 2009 and your first deposit was in 2018.. check those logs so the tool reflects your true portfolio's history and performance!

laresbernardo commented 5 years ago

I ran this and it worked just fine:

library(lares)
setwd("~/Desktop") # This is were I had the file you sent me
df <- get_stocks(filename = "emma.xlsx") # Changed name to be sure it wasn't the dummy one!
dfp <- stocks_objects(df)

And to generate the full HTML report: stocks_html(dfp)

emmagriff commented 5 years ago

This worked!! Thanks so much Lares!!

emmagriff commented 5 years ago

Hey Lares!

Can you tell me what the gray plot represents versus the red and blue lines in the first plot? The axes say daily var and % var. I’m assuming variance?

Let me know,

Thanks for your help!

Emma

On Fri, Mar 1, 2019 at 10:55 AM laresbernardo notifications@github.com wrote:

I ran this and it worked just fine:

library(lares) setwd("~/Desktop") # This is were I had the file you sent me! df <- get_stocks(filename = "emma.xlsx") dfp <- stocks_objects(df)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/laresbernardo/lares/issues/10#issuecomment-468752594, or mute the thread https://github.com/notifications/unsubscribe-auth/At54eYXhiVT0d8VLRNiIy39sJ6c7EwgUks5vSWl2gaJpZM4bZgLK .

laresbernardo commented 5 years ago

Yes, daily and overall variance. Red bars are negative, green bars positive and the black line is the cumulative variance since beginning of times

emmagriff commented 5 years ago

Yea but how can you have negative variance?

On Thu, Mar 7, 2019 at 11:43 AM laresbernardo notifications@github.com wrote:

Yes, daily and overall variance. Red bars are negative, green bars positive and the black line is the cumulative variance since beginning of times

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/laresbernardo/lares/issues/10#issuecomment-470645519, or mute the thread https://github.com/notifications/unsubscribe-auth/At54eYgBvWzummyw3reLQHwebrTcrzDAks5vUV3QgaJpZM4bZgLK .

laresbernardo commented 5 years ago

If the previous date the value was 100 and today is 95, then the variance would be (-)5%