search

laresbernardo / lares

Analytics & Machine Learning R Sidekick
https://laresbernardo.github.io/lares/
233 stars 49 forks source link

Update forecasting.R #17

Closed nfultz closed 5 years ago

nfultz commented 5 years ago

Light refactoring as I read your code. I generally recommend not using dplyr pipes in packages, but YMMV.

laresbernardo commented 5 years ago

Thanks @nfultz for your comments and codes. Your first commit (https://github.com/laresbernardo/lares/pull/17/commits/9732ef5f6ab6a9007dff6e643b6c0b84834445b7) has been approved; thanks! Those were actually one of the first lines of code I wrote with R (about 3 years ago!). The other two have issues so I can't branch them in yet :(

laresbernardo commented 5 years ago

Also added rlang dependency for quo_is_null function used

nfultz commented 5 years ago

Was it not already imported? You were using quosures?

laresbernardo commented 5 years ago

Plots aren't working with this merge: Error in signif(plot$p, 4)

laresbernardo commented 5 years ago

Fixed in my last commit: https://github.com/laresbernardo/lares/commit/2d2c11dbf77e9c66d886f6b7c25f8fe110cca7c6 You supressed p and pcum columns