wrong categorization in missingness

Hey laresbernardo, thanks for the very nice package! I'm currently investigating several packages for EDA, yours has a very broad range!

The missingness function has a slight bug - it's displaying not all variables containing NA in the "with" section and does not calculate percentage missing for them.

https://github.com/laresbernardo/lares/blob/6b87a600ec4ed1074e0974b2e651879d2876b113/R/missings.R#L30-L61

I've found this is due to tidyr::gather not working as expected and can be easily solved by using the new function tidyr::pivot_longer

Here I have the plot function (I also used glue for paste in the note)

if (plot) {
  obs <- nrow(df) * ncol(df)
  miss <- sum(m$missing)
  missp <- 100 * miss/obs
  note <- glue::glue(
    "Total values: {lares::formatNum(obs, 0)} | ",
    "Total missings: {lares::formatNum(miss, 0)} ",
    "({lares::formatNum(missp, 1)}%)"
  )
  p <- df %>% mutate_all(is.na) %>% 
    tidyr::pivot_longer(cols = tidyselect::everything()) %>%
    {if (!full) filter(., name %in% m$variable) else .} %>% 
    mutate(type = ifelse(name %in% m$variable, "with", "without")) %>% 
    group_by(name) %>% 
    mutate(row_num = row_number()) %>% 
    mutate(perc = round(100 * sum(value)/nrow(df), 2)) %>% 
    mutate(label = ifelse(type == "with", paste0(name, " | ", perc, "%"), name)) %>% 
    arrange(value) %>% 
    ggplot(aes(x = reorder(label, perc), y = row_num, fill = value)) + 
    geom_raster() + 
    coord_flip() + 
    {if (full) facet_grid(type ~ ., space = "free", scales = "free")} + 
    {if (summary) lares::scale_y_comma(note, expand = c(0, 0)) else lares::scale_y_comma(NULL, expand = c(0, 0))} + 
    scale_fill_grey(name = NULL, labels = c("Present", "Missing"), expand = c(0, 0)) + 
    labs(title = "Missing values", x = "", subtitle = if (!is.na(subtitle)) subtitle) + 
    lares::theme_lares2(legend = "top") + 
    theme(axis.text.y = element_text(size = 8))

  return(p)
}

laresbernardo / lares

wrong categorization in missingness #21