search

laresbernardo / lares

Analytics & Machine Learning R Sidekick
https://laresbernardo.github.io/lares/
233 stars 49 forks source link

Working with factors #8

Closed yousrihajri closed 5 years ago

yousrihajri commented 5 years ago

Hi Bernardo Thanks for the function plot_timeline which is very useful My remark is that the function doesn't handle repeated Role or Place since the number of factors should be equal to the number of rows. I have just tried the same job name in 2 different companies and it throws an error. Thanks

laresbernardo commented 5 years ago

You are absolutely right. Great point @yousrihajri Did you manage to fix that into the function or need some help with that?

ShanSabri commented 5 years ago

Another minor issues is that the factor levels for type is hardcoded. This causes problems in cases where we want to label "Work Experience" with "Professional Experience".

laresbernardo commented 5 years ago

Another minor issues is that the factor levels for type is hardcoded. This causes problems in cases where we want to label "Work Experience" with "Professional Experience".

Great observation @ShanSabri fixed! Please run devtools::install_github("laresbernardo/lares"), close RStudio and then reopen it to try it.

laresbernardo commented 5 years ago

Fixed the order issue because of the factor's properties @yousrihajri Now the plot will order the events as they are posted into the function, even though there are repeated values, using another dummy (hidden) variable. Thanks for catching it!

yousrihajri commented 5 years ago

It works, thanks !