search

largestgithubuseronearth / addwater

Installer for the Firefox GNOME theme
GNU General Public License v3.0
18 stars 2 forks source link

do not overwrite the user.js #12

Closed TheRsKing closed 14 hours ago

TheRsKing commented 23 hours ago

Describe the bug when a change is made, the entire user.js is overwritten. this has its disadvantages when using hardening such as betterfox etc.

To Reproduce Steps to reproduce the behavior:

  1. apply a custom user.js
  2. load the app and change something
  3. see how the user.js gets overwritten

Expected behavior instead of overwriting the content, simply make the changes and append them as it is done with the official curl script

Please include the log file from the day it happened Don't think there are any logs needed here, if there are, just ask me :)

Technical Details (please complete the following information):

gxanshu commented 21 hours ago

I was also having the same issue, i fixed and created a PR at #13

TheRsKing commented 20 hours ago

I was also having the same issue, i fixed and created a PR at #13

Amazing 🙏

largestgithubuseronearth commented 15 hours ago

Thank you for reporting this. My mistake.

Pushing the changes to Flathub in a moment.

largestgithubuseronearth commented 14 hours ago

The update should appear on Flathub within a few hours. Closing this now but please open another issue if the problem persists after updating the app.

TheRsKing commented 13 hours ago

grafik great it works. Also thanks for this very good app :)