search

largestgithubuseronearth / addwater

Installer for the Firefox GNOME theme
GNU General Public License v3.0
30 stars 2 forks source link

[FEATURE REQUEST] Well done! How about Mobile Support? #18

Open 1peter10 opened 2 weeks ago

1peter10 commented 2 weeks ago

Thank you for trying Add Water. Let me know whether you liked it or not and why.

Write your thoughts however is most convenient for you but here are some questions to help guide you on .

Have you encountered any bugs? Describe any bugs or weird behavior you've noticed. If you're unsure if something is a feature or bug, feel free to mention it here.

No. (Aside from expected bugs due combining the theme with mobile-config-firefox.) That said, it generally works, just some options are a bit dangerous in this unintended use-case.

What do you think of the graphical user interface? Is it simple, readable, and intuitive to make changes? Do the descriptions clearly describe what the option does? Is there any option or feature that did something different than what you expected?

I like it a lot, but I would really appreciate it, if the min-width in https://github.com/largestgithubuseronearth/addwater/blob/bc24b476adaf794d04c9f244d00d7ac67bdacc85/src/window.py#L47 could be 360.

Why? In order to use this app on Linux Phones and have the app be adaptive, 360 logical pixels width are the "golden bullet". See https://linuxphoneapps.org/docs/resources/developer-information/#hardware-specs-to-consider for reference.

If you are okay with supporting this as a min-width, I'll happily help with adding the things to metainfo to have the app marked as adaptive in GNOME Software (and feedback on which options should not be enabled on mobile) and add the app to LinuxPhoneApps.org.

What do you think of the Firefox styling? Do you enjoy how Firefox looks with the theme enabled? What are your favorite options?

Yes, very much!

Do you have any suggestions or requests? Feel free to suggest any feature or change that would make this app more helpful for you.

See above. Also, I think this (or a separate app basically reusing much of its code) would be nice to offer a simple and user friendly way to offer the customizations to firefox incorporated in

Would you be interested in using Add Water once it's finished? Does this app bring enough value to you? Why or why not?

Making customizations simple via flatpak is a huge step and very helpful for people not comfortable using the terminal.

largestgithubuseronearth commented 2 weeks ago

Proper mobile support is out of the scope of my plans but I'm okay with changing the minimum width.

I designed the app with an eye towards swapping out certain components in the future, so it would be cool to see someone make a version for Linux phones. There is potential in that idea but I already have my hands full as-is unfortunately.

Thank you for your feedback! I'm glad you find Add Water helpful.

largestgithubuseronearth commented 2 weeks ago

You should see the change to lower the screen width minimum in a few hours (v1.1.3). Let me know how it works for you.

I don't have plans for full support but I would accept a PR if you want to disable some of the theme's options on Linux Phone. I can't promise I won't break it in the future as changes are made, but I do want Add Water to be as helpful as possible for you. Are you interested?

1peter10 commented 2 weeks ago

Thank you, that's awesome, 1.1.3 fits the screen nicely again! :tada:

I'll put creating a PR on my to do list - I hope it won't take me too long!

I fully understand that you don't want to take this and can't promise that there won't be no breakage (as a contributor to mobile-config-firefox I am painfully aware that there are many moving parts in a project like this), and limiting scope is good for projects (and maintainers mental health). :slightly_smiling_face: :+1: