search

laristra / flecsi

A mirror of FleCSI's internal gitlab repository.
Other
67 stars 34 forks source link

Feature/staley/utils id more #596

Closed staleyLANL closed 5 years ago

staleyLANL commented 5 years ago

More cleanup to the utils id_ class.

ipdemes commented 5 years ago

@staleyLANL : did you check if FleCSALE-MM works with your changes?

staleyLANL commented 5 years ago

@ipdemes No, not yet. My flecsale-mm seems to have been broken lately; something about the python library. I don't know what changed in order to cause that.

staleyLANL commented 5 years ago

@ipdemes All tests pass for flecsale-mm with this branch on Darwin with MPI.

ipdemes commented 5 years ago

@staleyLANL : could you, please , also test with legion and update with the most recent master

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d0f77f5). Click here to learn what that means. The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #596   +/-   ##
========================================
  Coverage          ?   31.7%           
========================================
  Files             ?     139           
  Lines             ?    5733           
  Branches          ?     685           
========================================
  Hits              ?    1820           
  Misses            ?    3771           
  Partials          ?     142
Flag Coverage Δ
#clang 16.9% <0%> (?)
#gcc 30.9% <100%> (?)
Impacted Files Coverage Δ
flecsi/utils/common.h 50% <ø> (ø)
flecsi/utils/id.h 15.7% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0f77f5...67638b3. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d0f77f5). Click here to learn what that means. The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #596   +/-   ##
========================================
  Coverage          ?   31.7%           
========================================
  Files             ?     139           
  Lines             ?    5733           
  Branches          ?     685           
========================================
  Hits              ?    1820           
  Misses            ?    3771           
  Partials          ?     142
Flag Coverage Δ
#clang 16.9% <0%> (?)
#gcc 30.9% <100%> (?)
Impacted Files Coverage Δ
flecsi/utils/common.h 50% <ø> (ø)
flecsi/utils/id.h 15.7% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0f77f5...67638b3. Read the comment docs.

staleyLANL commented 5 years ago

@ipdemes Yes, I can do that; just remember that flecsale-mm's master branch with legion on Darwin fails those three tests. I can verify that the utils::id changes don't cause it to fail additional tests.

staleyLANL commented 5 years ago

@ipdemes I ran the flecsale-mm tests again on Darwin this morning. With mpi, all tests pass both with flecsi master, and flecsi with this branch. With legion, those same three tests fail both with flecsi master, and with my branch. Whatever the problem is with legion, I believe that my utils-id-more branch is fine, because results are consistent with those of master.