laristra / flecsi

A mirror of FleCSI's internal gitlab repository.
Other
67 stars 34 forks source link

fixed logic for global handle #598

Closed ipdemes closed 5 years ago

ipdemes commented 5 years ago

Global can be modified in a single task anywhere during the execution

codecov[bot] commented 5 years ago

Codecov Report

Merging #598 into master will increase coverage by 5.6%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #598     +/-   ##
========================================
+ Coverage    25.3%   30.9%   +5.6%     
========================================
  Files         174     127     -47     
  Lines        8987    4619   -4368     
  Branches      913     630    -283     
========================================
- Hits         2280    1431    -849     
+ Misses       6565    2997   -3568     
- Partials      142     191     +49
Flag Coverage Δ
#clang ?
#gcc 30.9% <ø> (+8.5%) :arrow_up:
Impacted Files Coverage Δ
flecsi/coloring/communicator.h 0% <0%> (-100%) :arrow_down:
flecsi/execution/common/function_handle.h 0% <0%> (-100%) :arrow_down:
flecsi/execution/function.h 0% <0%> (-100%) :arrow_down:
flecsi/topology/mesh_definition.h 0% <0%> (-100%) :arrow_down:
flecsi/data/global_accessor.h 18.1% <0%> (-81.9%) :arrow_down:
flecsi/utils/demangle.cc 0% <0%> (-71.5%) :arrow_down:
flecsi/utils/array_ref.h 34.3% <0%> (-65.7%) :arrow_down:
flecsi/utils/tuple_function.h 0% <0%> (-60%) :arrow_down:
flecsi/utils/dimensioned_array.h 44.4% <0%> (-55.6%) :arrow_down:
flecsi/data/dense_accessor.h 17.6% <0%> (-52.4%) :arrow_down:
... and 154 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 018603b...72eb566. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #598 into master will increase coverage by 5.6%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #598     +/-   ##
========================================
+ Coverage    25.3%   30.9%   +5.6%     
========================================
  Files         174     127     -47     
  Lines        8987    4619   -4368     
  Branches      913     630    -283     
========================================
- Hits         2280    1431    -849     
+ Misses       6565    2997   -3568     
- Partials      142     191     +49
Flag Coverage Δ
#clang ?
#gcc 30.9% <ø> (+8.5%) :arrow_up:
Impacted Files Coverage Δ
flecsi/coloring/communicator.h 0% <0%> (-100%) :arrow_down:
flecsi/execution/common/function_handle.h 0% <0%> (-100%) :arrow_down:
flecsi/execution/function.h 0% <0%> (-100%) :arrow_down:
flecsi/topology/mesh_definition.h 0% <0%> (-100%) :arrow_down:
flecsi/data/global_accessor.h 18.1% <0%> (-81.9%) :arrow_down:
flecsi/utils/demangle.cc 0% <0%> (-71.5%) :arrow_down:
flecsi/utils/array_ref.h 34.3% <0%> (-65.7%) :arrow_down:
flecsi/utils/tuple_function.h 0% <0%> (-60%) :arrow_down:
flecsi/utils/dimensioned_array.h 44.4% <0%> (-55.6%) :arrow_down:
flecsi/data/dense_accessor.h 17.6% <0%> (-52.4%) :arrow_down:
... and 154 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 018603b...72eb566. Read the comment docs.

tuxfan commented 5 years ago

Merge after CI.