laristra / flecsi

A mirror of FleCSI's internal gitlab repository.
Other
67 stars 34 forks source link

Merge task.hh into execution.hh #627

Closed opensdh closed 5 years ago

opensdh commented 5 years ago

The existing interface is just forwarders for context_t functions, which can instead be exposed by giving flecsi::runtime::context_t::instance() the easier name of flecsi::context() (as opposed to flecsi::runtime::context, the base class). execution.hh would then be nothing but an #include of runtime/backend.hh to get that function, so rename task.hh to it.

staleyLANL commented 5 years ago

YES, in my opinion at least. I like minimally cluttered verbiage and relatively "flat" name hierarchies where possible.

opensdh commented 5 years ago

YES, in my opinion at least. I like minimally cluttered verbiage and relatively "flat" name hierarchies where possible.

You'll really like one of my next pull requests, then…

opensdh commented 5 years ago

Rebased to resolve (trivial) merge conflicts.

opensdh commented 5 years ago

Now merely merges the contents of task.hh in, leaving context_t::instance() alone since @tuxfan said he wanted that to remain ugly (to discourage casual use).