Adapting to HPX V1.5 - Githubissues

hkaiser commented 4 years ago

This patch adds some conditional changes that a required to make flecsi/1 compile with HPX V1.5

hkaiser commented 4 years ago

This has been completely redone (please note I force-pushed to the underlying branch). The changes unrelated to HPX have now been separated and are available as #645. This PR has now only changes that are required to have HPX V1.5 as a backend.

hkaiser commented 4 years ago

Please also note that this PR depends on laristra/cinch#187

hkaiser commented 4 years ago

@opensdh, @ipdemes: I have addressed all review comments as discussed. Please note that I have pushed additional changes to https://github.com/laristra/cinch/pull/187.

ollielo commented 4 years ago

The probably will be better answered by Irina.

On Mon, Nov 30, 2020 at 4:24 PM Hartmut Kaiser notifications@github.com wrote:

@hkaiser commented on this pull request.

In flecsi/execution/hpx/task_add_dependencies.h https://github.com/laristra/flecsi/pull/643#discussion_r532968834:

indices of the index partition.

*/

template<typename T,

size_t EXCLUSIVE_PERMISSIONS,

size_t SHARED_PERMISSIONS,

size_t GHOST_PERMISSIONS>

void handle(dense_accessor<T,

EXCLUSIVE_PERMISSIONS,

SHARED_PERMISSIONS,

GHOST_PERMISSIONS> & a) {

auto & h = a.handle;

// Skip Read Only handles

if constexpr((SHARED_PERMISSIONS == ro) || (GHOST_PERMISSIONS == rw) ||

Thanks for this explanation. I'm still unsure about the role of the various permissions, though. Would you be able to recommend some documentation or similar to read up about this?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/laristra/flecsi/pull/643#discussion_r532968834, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFRR5JXEZI5DLICUHNNNZLSSQSTHANCNFSM4PSV3XJQ .

laristra / flecsi

Adapting to HPX V1.5 #643

@hkaiser commented on this pull request.