search

larixer / hid-asus-dkms

ASUS HID FTE100* DKMS Driver
GNU General Public License v2.0
68 stars 10 forks source link

Full code review #15

Closed larixer closed 7 years ago

larixer commented 7 years ago

@bentiss Thank you very much for your review. We will try to change code to address all your points raised in comments.

The interesting point is whether this is Asus or Elan touchad. They do certainly share some HID protocol implementation details in common, but there are differences as well. This device is certainly not branded as Elan neither on hardware nor in firmware.

If we assume this device is Elan, this will mean we should integrate the code with drivers/input/mouse/elan_i2c*, right?

redmcg commented 7 years ago

@vlasenko With the patch accepted by the hid core maintainer - I think we can close (or complete) this pull request?

@bentiss Thanks once again for your assistance on this one

larixer commented 7 years ago

@redmcg Cool. Thank you very much for all your hard work, Brendan.

As for this PR, I think we are fine to close it and that's what I will do now.

larixer commented 6 years ago

@bentiss We really need your opinion on this issue, please: https://github.com/vlasenko/hid-asus-dkms/issues/54 We need someone to tell us how things are supposed to work in the kernel for tracking ids assignment.

bentiss commented 6 years ago

Sure, I had a look and answered there.

larixer commented 6 years ago

@bentiss Many thanks Benjamin!