Incorrect line info returned when error occurs

[jillyj]

Grammar file: https://github.com/opencybersecurityalliance/kestrel-lang/blob/develop/src/kestrel/syntax/kestrel.lark Generated parser: kestrelParser.js.zip

Code to parse string disp a\nproc2 = get. The 1st line disp a is valid string. The 2nd line proc2=get is invalid and should return error. However, the exception I got from parser told me the error occurs at line 1. I checked the parser, and it uses \n as newline char, so it should return line 2 has error.

function handle_errors(e) { return true; }

  try {
    treeData = parser.parse("disp a\nproc2 = get", null, handle_errors).children[0];
  } catch (e) {
    console.debug("uncaught error:", e)
  }

Expected: the exception should return correct line number where the error occurs.

[jillyj]

@erezsh could you please take a look at this issue?

[erezsh]

Fixed in master

[jillyj]

The fix works. Thank you!

[erezsh]

Happy to help