search

lark-parser / Lark.js

Live port of Lark's standalone parser to Javascript
MIT License
71 stars 12 forks source link

build: allow any v0 lark version after 0.11.1 #9

Closed zevisert closed 2 years ago

zevisert commented 2 years ago

Closes #8.

I know you're running two equivalent packages, lark and lark-parser, but the suggested name over in lark-parser/lark is just lark, so I changed that here too.

zevisert commented 2 years ago

I can include a version bump to 0.0.8 for lark-js here too if you want!

erezsh commented 2 years ago

Thank you for the PR!

Btw Lark 1.0 was released today.

zevisert commented 2 years ago

Congratulations @erezsh! It's been a long road, and I'll be stoked to go try it out!

I can put in another PR here for the bump to v1 if you'd like. But having played with lark.js now a bunch, I think there's more to the live port than just bumping these python versions. I presume you used erezsh/py2js to generate Lark.js/lark.js? We'd still have to run that again with the v1 release right?

Also, I have a typescript module declaration in progress that I can eventually contribute back here too!

erezsh commented 2 years ago

Thanks! Yes, it's been a long road, and hopefully we did a good enough job that a v2 won't be necessary anytime soon.

Yes, the conversion isn't perfect, and needs a little bit of manual adjustment. Also v1 changes a lot of internals, so I'm sure it will take a bit of work to get it to align again. But I'm planning to do it soon. Also seems like pyanalyze has improved since, so maybe it will even produce better code.

Also, I have a typescript module declaration in progress that I can eventually contribute back here too!

That's great! I'd be happy to add that.

Btw just in case you're not aware of it, there is a project to make lark.js easy to use with webpack - https://github.com/ShawSumma/webpack-lark-loader. It's already working, it's just not well documented.

erezsh commented 2 years ago

@zevisert Just FYI, latest master is now upgraded and uses Lark v1.0.

I'll make a release soon, but meanwhile I'll be happy to hear any input you might have!