search

lark-parser / lark

Lark is a parsing toolkit for Python, built with a focus on ergonomics, performance and modularity.
MIT License
4.88k stars 414 forks source link

setup.cfg: Replace deprecated license_file with license_files #1209

Closed mgorny closed 2 years ago

mgorny commented 2 years ago

Replace the deprecated license_file key with license_files. The latter has the same semantics and is available since setuptools 42.0.0 (that lark already requires).

erezsh commented 2 years ago

Is there a reason to change this? Is license_file ever going to get dropped?

mgorny commented 2 years ago

Is there a reason to change this?

Right now it triggers verbose deprecation warnings that trigger our QA pipelines.

Is license_file ever going to get dropped?

Hard to tell. I've asked setuptools a more general question about timeline for dropping deprecated stuff, and got no answer. However, they definitely did remove some deprecated stuff in the past.

erezsh commented 2 years ago

verbose deprecation warnings

Fair enough.

mgorny commented 2 years ago

Thanks for bearing with me. This is really appreciated.

erezsh commented 2 years ago

No problem, thanks for making Lark a tiny bit better.