search

lark-parser / lark

Lark is a parsing toolkit for Python, built with a focus on ergonomics, performance and modularity.
MIT License
4.75k stars 401 forks source link

Add an error message when using Lark.save() when parser!='lalr' #1328

Closed erezsh closed 1 year ago

erezsh commented 1 year ago

Addresses an oversight raised in issues #1323 and #788

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.02% :warning:

Comparison is base (656334c) 89.22% compared to head (ae6f43a) 89.21%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1328 +/- ## ========================================== - Coverage 89.22% 89.21% -0.02% ========================================== Files 51 51 Lines 7595 7597 +2 ========================================== + Hits 6777 6778 +1 - Misses 818 819 +1 ``` | [Flag](https://app.codecov.io/gh/lark-parser/lark/pull/1328/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lark-parser) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/lark-parser/lark/pull/1328/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lark-parser) | `89.21% <50.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lark-parser#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/lark-parser/lark/pull/1328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lark-parser) | Coverage Δ | | |---|---|---| | [lark/lark.py](https://app.codecov.io/gh/lark-parser/lark/pull/1328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lark-parser#diff-bGFyay9sYXJrLnB5) | `85.62% <50.00%> (-0.23%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.