lark-parser / lark

Lark is a parsing toolkit for Python, built with a focus on ergonomics, performance and modularity.
MIT License
4.81k stars 409 forks source link

Fix 1345 attempt two #1347

Closed MegaIng closed 1 year ago

MegaIng commented 1 year ago

Alternative to #1346

erezsh commented 1 year ago

I like this one better!

MegaIng commented 1 year ago

The only benefit of #1346 is that it exposes the option to skip callbacks to the end user, in case they want to do something like a deeper accepts. Otherwise I don't think there is any benefit one way or the other, except that this is less code

erezsh commented 1 year ago

I tend to prefer this version because -

Anyway, thanks for making both versions! I'll sleep on it, and if there's no new information or arguments, I'll probably merge this one.