Open MegaIng opened 2 weeks ago
Is there anything I can do to get 1388 merged faster?
You currently still have an outstanding "Request Changing" review that I think Ross thinks is fully resolved. If you have changes other than the latest I suggested, you can already suggest them, otherwise you could add a review "Comment" to clear the "Requesting Changes" review status.
I added a few comments.
And I'm working through those comments.
This is a list of TODOs I would like to see/do after #1388 is merged (or independently, but reviewing that PR is why I am now making this list):
Doc changes
_rules
are inlined after parsing, not before parsing, preparing for potentially addition of__rule
syntax, and preempting confusion about this (since this has semantic differences, especially with respect tolalr
)lark
syntax highlighting instead of misusingperl
.Code changes
%declare
rules so that they can later be implemented with either%override
or more importantly%extend
, useful for plugin features.LarkValidator
into something that can be used byload_grammar.py
find_grammar_errors
intolark_validator.py
, and probably make it uselark.lark
find_grammar_errors
to do semantic checks usingLarkValidator
(and therefore add the ability toLarkValidator
to report multiple issues)lark.lark
into a BNF representation that can be used byload_grammar.py
- For example, alark.bnf.json
file loaded by the stdlib module. (We could potentially also "cache" the lalr parse tables in a json file. If we expose this build tool inside oflark.tools
, together with aload
function, this could be a more lightweight alternative to standalone)