lark-parser / lark

Lark is a parsing toolkit for Python, built with a focus on ergonomics, performance and modularity.
MIT License
4.8k stars 409 forks source link

Update config and drop python < 3.8 #1430

Closed MegaIng closed 3 months ago

MegaIng commented 3 months ago

This PR consists of 2 parts:

It removes python code specific to python 3.6/3.7 (and some only relevant for 2.7 that we forgot!)

It updates quite a bit config, although it's little "real" changes. I list them here as checkboxes so that you @erezsh can check them off if you agree with them

erezsh commented 3 months ago

Looks good!

As for codecov, ideally I would like it to work for everyone. I have the CODECOV_TOKEN env var set for the repo. Do you have any idea why it doesn't work for you?

Also, I think the version bump commit should be part of this PR. Feel free to do it, or I can create and push it here if you prefer.

MegaIng commented 3 months ago

I have the CODECOV_TOKEN env var set for the repo. Do you have any idea why it doesn't work for you?

Because quite reasonably, it's a secret so that it's not publicly accessible, and to specifically prevent everyone from pushing stuff to codecov.

erezsh commented 3 months ago

Well, I'd still like to fix codecov for all pull requests, but I suppose it doesn't have to be in this PR.

So, is it ready for merge?

MegaIng commented 3 months ago

Ok, looks like the codecov action is currently a bit buggy: https://github.com/codecov/codecov-action/issues I am going to revert these commits and we can try again in a few weeks.

MegaIng commented 3 months ago

Now we are ready to merge.