search

lark-parser / lark

Lark is a parsing toolkit for Python, built with a focus on ergonomics, performance and modularity.
MIT License
4.62k stars 395 forks source link

Disable ForestToParseTree cache when ambiguity='resolve' #1433

Closed chanicpanic closed 1 week ago

chanicpanic commented 1 week ago

Fixes #1283.

erezsh commented 1 week ago

Lgtm.

I think maybe it's a good idea to add a comment explaining that caching is disabled because of the tree construction, or mention the issue number? Because it's not an obvious connection imho.

chanicpanic commented 1 week ago

I think maybe it's a good idea to add a comment explaining that caching is disabled because of the tree construction, or mention the issue number? Because it's not an obvious connection imho.

Good idea, added.

erezsh commented 1 week ago

Thanks!