lark-parser / lark

Lark is a parsing toolkit for Python, built with a focus on ergonomics, performance and modularity.
MIT License
4.62k stars 395 forks source link

Bugfix for issue #1434 #1435

Closed erezsh closed 1 week ago

erezsh commented 1 week ago

Fixes #1434

codecov-commenter commented 1 week ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.77%. Comparing base (5016894) to head (7547758).

Files Patch % Lines
lark/utils.py 50.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1435 +/- ## ========================================== - Coverage 89.78% 89.77% -0.01% ========================================== Files 52 52 Lines 7811 7818 +7 ========================================== + Hits 7013 7019 +6 - Misses 798 799 +1 ``` | [Flag](https://app.codecov.io/gh/lark-parser/lark/pull/1435/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lark-parser) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/lark-parser/lark/pull/1435/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lark-parser) | `89.77% <90.90%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lark-parser#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

erezsh commented 1 week ago

Not much to review but I'll follow protocol just in case.

MegaIng commented 1 week ago

If this is a bugfix, we should have tests that fail (sometimes) beforehand.

Although, for that we ideally had infrastructure to start a new process with different, controllable hash seeds which then execute the snippet we want to check out.

erezsh commented 1 week ago

Added. Anything else?