Add Tree.find_token() method

lark-parser / lark

Lark is a parsing toolkit for Python, built with a focus on ergonomics, performance and modularity.

MIT License

4.81k stars 409 forks source link

Open makukha opened 3 weeks ago

makukha commented 3 weeks ago

Resolves #1466.

makukha commented 3 weeks ago

I put this method outside of "standalone" scope as it uses scan_values() that is not included as well. Not sure if this is correct.

makukha commented 3 weeks ago

@erezsh ready for review.

erezsh commented 3 weeks ago

Overall looks good. A few requests:

Add a test
Rename typ to token_type
Clarify in the docstring that it is a recursive function, i.e. it will find tokens in all the subtrees.

makukha commented 3 weeks ago

I changed isinstance(v, Token) to not isinstance(v, Tree) (same as in _pretty()) to avoid importing Token.

@erezsh ready for review.